Skip to content

add sidebar #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add sidebar #2

wants to merge 4 commits into from

Conversation

@orhan-swe
Copy link

@orhan-swe orhan-swe commented Jun 2, 2018

pull request for issue #1
To see how it looks (this is a temporary link):
http://18.196.145.205/html-css-cheat-sheet/html/html-cheat-sheet.html

I moved the file to ./html/html-cheat-sheet.html so server needs to be updated

@acchou
Copy link
Owner

acchou commented Jun 4, 2018

Thanks for taking a first stab at this. Some suggestions:

  • I'm not sure the hamburger menu works for laptop size resolutions. Part of the value of the sidebar is to be visible for easily jumping around, but the hamburger menu isn't visible if you're scrolled past the top.
  • I like the Webpack documentation sidebar as an example: https://webpack.js.org/concepts/.
  • In terms of file structure, we should have an index.html at the toplevel to make it easier to understand where to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@orhan-swe @acchou